Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Gamma Adjustment with Brightness Adjustment #7704

Merged
merged 8 commits into from
Feb 7, 2025

Conversation

kphoenix137
Copy link
Collaborator

@kphoenix137 kphoenix137 commented Feb 3, 2025

Gamma adjustment is extremely ugly. Replaced it with a more refined system that preserves the look of the game, but makes it less dark and easier to see on low brightness displays.

image

image

100% brightness level was configured to closely match the "intensity" of gamma at 100%. This is roughly a 100% brightness increase in the midtones from the vanilla pallette, with varying brightness increases in the low tones and high tones.

@kphoenix137
Copy link
Collaborator Author

kphoenix137 commented Feb 3, 2025

My clang formatting script doesn't agree with what CI thinks is proper clang formatting apparently.

@StephenCWills
Copy link
Member

We recently bumped from clang-format-13 to clang-format-18, which did tweak some rules. Try to match the version as closely as possible.

Max brightness to max intensity amount as Gamma at 100%
@kphoenix137 kphoenix137 closed this Feb 3, 2025
@kphoenix137 kphoenix137 reopened this Feb 3, 2025
@kphoenix137
Copy link
Collaborator Author

@AJenbo can you re-run tests?

@StephenCWills
Copy link
Member

That red x was making you anxious, huh?

Source/engine/palette.cpp Outdated Show resolved Hide resolved
Source/engine/palette.cpp Outdated Show resolved Hide resolved
kphoenix137 and others added 2 commits February 4, 2025 11:12
Co-authored-by: Gleb Mazovetskiy <[email protected]>
Co-authored-by: Gleb Mazovetskiy <[email protected]>
Copy link
Member

@AJenbo AJenbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot nicer then what I expected, I thought you might have just renamed "Gamma" to "Brightness" to make it "easier" to understand :D

@AJenbo AJenbo merged commit 13a5ae4 into diasurgical:master Feb 7, 2025
23 checks passed
@kphoenix137 kphoenix137 deleted the gamma-replacement branch February 7, 2025 23:36
@kphoenix137
Copy link
Collaborator Author

This is a lot nicer then what I expected, I thought you might have just renamed "Gamma" to "Brightness" to make it "easier" to understand :D

Expectations have never been lower 🥲

@AJenbo
Copy link
Member

AJenbo commented Feb 8, 2025

Feed back from a visually impaired player:

this second one does seem better, for me the original gamma isn't too much of an issue, I think? The big stuff for me in this case is the text elements, and other UI menus, and those look pretty good when I ran them at a lower resolution.

So this fit very well with the 1.6.0 goals :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants