-
Notifications
You must be signed in to change notification settings - Fork 818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Gamma Adjustment with Brightness Adjustment #7704
Conversation
My clang formatting script doesn't agree with what CI thinks is proper clang formatting apparently. |
We recently bumped from |
Max brightness to max intensity amount as Gamma at 100%
@AJenbo can you re-run tests? |
That red x was making you anxious, huh? |
Co-authored-by: Gleb Mazovetskiy <[email protected]>
Co-authored-by: Gleb Mazovetskiy <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a lot nicer then what I expected, I thought you might have just renamed "Gamma" to "Brightness" to make it "easier" to understand :D
Expectations have never been lower 🥲 |
Feed back from a visually impaired player:
So this fit very well with the 1.6.0 goals :) |
Gamma adjustment is extremely ugly. Replaced it with a more refined system that preserves the look of the game, but makes it less dark and easier to see on low brightness displays.
100% brightness level was configured to closely match the "intensity" of gamma at 100%. This is roughly a 100% brightness increase in the midtones from the vanilla pallette, with varying brightness increases in the low tones and high tones.