-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use position for object delta messages #5174
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephphatha
commented
Aug 1, 2022
b354634
to
bd35a18
Compare
ephphatha
commented
Aug 2, 2022
AJenbo
reviewed
Aug 2, 2022
Co-authored-by: Stephen C. Wills <[email protected]> Co-authored-by: Anders Jenbo <[email protected]>
AJenbo
approved these changes
Aug 2, 2022
StephenCWills
approved these changes
Aug 2, 2022
Thanks for solving this :) |
Getting a warning:
|
GCC warns on code that is valid in C++17 but was undefined before that standard, even if the language level is set to a modern version :/ Can use #5181 to avoid the warning |
This is actually useful for us because some platforms do not fully support C++17 (only Amiga by now actually) |
and my PowePC :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the worst case this ends up increasing the size of the DLevel object by 127*2 bytes (since we now need to track object position in the delta) + map overhead. Having said that deltas are only really needed for objects which actually allow interaction. Decorations no longer get a delta since they never change. Actual network traffic is compressed so should end up about the same in practice.
Static memory usage increases by 127*2+1 bytes unfortunately due to the use of
sgRecvBuf
. Hard to tell if we even need this chunk of memory to be on the stack given the use inOnLevelData()
.fixes #5172