Repository navigation
The installer's file types become a Components tree, with a Shortcuts & Right-Click Menu page - #53
Merged
Merged
Conversation
…& Right-Click Menu page asks about both shortcuts
- Choose File Types is MUI's Components page: a branch per file type group, expanded, a box per extension,
the Open With line on top, skipped on an update. electron-builder's "install" section is hidden by its
index, and the build fails if that index ever moves.
- Shortcuts & Right-Click Menu: "Add a desktop shortcut", "Add a Start menu shortcut" and the right-click
entry, all ticked ("Shortcuts" for an app without an entry). The choices are kept as KitDesktopShortcut
and KitStartMenuShortcut; /NODESKTOPSHORTCUT (or --no-desktop-shortcut) and /NOSTARTMENUSHORTCUT choose
silently. Each shortcut is matched to its box; an update never makes one. Without a Start menu shortcut,
Run starts the app itself.
- Tick All, Untick All and the page's column limit go. A group's name can't start with - or !.
- The demo gains a second group (Data File: json, csv).
- scripts/capture-installer.ps1 steps through the installer's and uninstaller's pages and saves a PNG of
each; Windows CI runs it and keeps them 3 days. check-installer.ps1 checks the shortcuts.
… PowerShell 7 as in 5.1, and never clicks a page caught as it changes
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The installer's two pages after "Who it's for", and the shortcuts they ask about.
customInstallreads them. electron-builder's own "install" section is hidden by its index (SectionSetTextincustomInit), andcustomInstallhas a compile-time!if ${INSTALL_SECTION_ID} != <n>!error, so if electron-builder ever moves that section the build fails instead of shipping a stray box.KitDesktopShortcutandKitStartMenuShortcut, and the new silent switches are/NODESKTOPSHORTCUT(or--no-desktop-shortcut) and/NOSTARTMENUSHORTCUT.$launchLinkis the exe, so Run and--force-runstill start the app.-or!(NSIS would hide the branch or make it bold).Data File(json,csv).scripts/capture-installer.ps1runs the installer and uninstaller with their pages showing, clicks Next with Win32 messages and saves a PNG of each page. Windows CI runs it aftercheck-installer.ps1and uploads the PNGs as a 3-day artifact.check-installer.ps1now also checks the shortcuts:--updatedkeeps them gone;--force-runwithout a Start menu shortcut starts the app;docs/building.md: the pages, the switches, and a note that without a Start menu shortcut Windows doesn't deliver the app's notifications (Electron still reports them as shown).Checked locally:
npm test256/256. The demo, a 22-type shape and an entry-only shape all compile undermakensis -WX, and the capture of each was looked at.check-installer.ps1passed per user; the install for everyone runs in CI.