Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine get_interactions for drugs and genes #26

Open
jsstevenson opened this issue Apr 3, 2024 · 4 comments
Open

Combine get_interactions for drugs and genes #26

jsstevenson opened this issue Apr 3, 2024 · 4 comments
Labels
priority:medium Medium priority stale-exempt technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"

Comments

@jsstevenson
Copy link
Contributor

I'm sort of surprised there's no graphql endpoint that can search on both at once, but I guess I'm not sure how exactly it would work (union or intersection?). Given that, we should just split this thing into separate methods, since it's really doing two separate things.

@jsstevenson jsstevenson added priority:medium Medium priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup" labels Apr 3, 2024
@jsstevenson
Copy link
Contributor Author

Also, both should return the same structure of object IMO

@jsstevenson
Copy link
Contributor Author

They should also return some stuff about InteractionTypes.

@jsstevenson
Copy link
Contributor Author

In this commit, we changed the drugs query to do a left anchored search on names -- I think for autocomplete reasons? However, this means that if you eg use the get_interactions() method here and just search for "b" you will get like a hundred different drugs.

It might be smart to change the name of the field in the drugs query to a special one for the left anchored search and keep names as an exact match. Really, though, we should just be able to search for interactions by drug/gene directly, so it might be better to focus on that.

@jsstevenson jsstevenson changed the title Separate get_interactions into separate methods for drugs and genes Combine get_interactions for drugs and genes Apr 26, 2024
Copy link

This issue is stale because it has been open 135 days with no activity. This issue will be closed if no further activity occurs in 14 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:medium Medium priority stale-exempt technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"
Projects
None yet
Development

No branches or pull requests

1 participant