Skip to content

fix: Fix the workflow that adds the interface-spec label #5243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

dsarlis
Copy link
Member

@dsarlis dsarlis commented Feb 13, 2025

When a PR is submitted from a fork from an external contributor, the workflow that attempts to add the interface-spec label fails, e.g. on this PR.

According to actions/labeler#36 (comment) this should be fixed by changing the type of action that triggers the workflow from pull_request to pull_request_target as this adds the necessary write permissions through a github token.

When a PR is submitted from a fork from an external contributor, the workflow that attempts to add the `interface-spec` label fails, e.g. on this [PR](#5240).

According to actions/labeler#36 (comment) this should be fixed by changing the type of action that triggers the workflow from `pull_request` to `pull_request_target` as this adds the necessary write permissions through a github token.
@dsarlis dsarlis requested a review from a team as a code owner February 13, 2025 15:53
@dsarlis dsarlis enabled auto-merge (squash) February 13, 2025 17:21
@dsarlis dsarlis merged commit cfaf592 into master Feb 14, 2025
6 checks passed
@dsarlis dsarlis deleted the dsarlis-patch-1 branch February 14, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants