Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): Fix testnet title and transitions in network switcher #5477

Conversation

daviddecentage
Copy link
Collaborator

Motivation

After the network switcher refactoring there has been the issue that transitions dont work properly for enabled/disabled testnet. Also, the testnet title is visible even if testnet is disabled.

Changes

Fixed transitions and testnet title when testnet is disabled

Tests

image
image

@daviddecentage daviddecentage requested a review from a team as a code owner March 27, 2025 15:16
@daviddecentage daviddecentage enabled auto-merge (squash) March 27, 2025 15:17
Copy link
Collaborator

@AntonioVentilii AntonioVentilii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tks! One observation:

…x(frontend)/transition-and-testnet-title-network-switcher

# Conflicts:
#	src/frontend/src/lib/components/networks/NetworksSwitcher.svelte
…tnet-title-network-switcher' into fix(frontend)/transition-and-testnet-title-network-switcher
@daviddecentage daviddecentage enabled auto-merge (squash) March 28, 2025 13:08
@daviddecentage daviddecentage merged commit 1fc8ec7 into main Mar 28, 2025
25 checks passed
@daviddecentage daviddecentage deleted the fix(frontend)/transition-and-testnet-title-network-switcher branch March 28, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants