feat(frontend): load user profile during login #5460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // So we need to load it first to enable/disable the rest of the services. | ||
| const { success: userProfileSuccess } = await loadUserProfile({ identity: $authIdentity }); | ||
|
|
||
| if (!userProfileSuccess) { |
There was a problem hiding this comment.
We better make this endpoint bulletproof :)
There was a problem hiding this comment.
Maybe it's worth adding some retry mechanism here? Not in this PR
There was a problem hiding this comment.
Yes, makes sense! Will work on it in another PR (inside service loadUserProfile)
DenysKarmazynDFINITY
approved these changes
Mar 28, 2025
AntonioVentilii
deleted the
feat(frontend)/load-user-profile-during-login
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are going to save the enabled/disabled networks in the backend, in the user profile. So, we need to load the user profile before all the other services, to avoid doing work for disabled networks.
Changes
loadUserProfilein theonMountofLoadercomponent, before the addresses.Tests
No changes in local replica.