Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(IDX): load ledger suite orchestrator wasm directly #4322

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nmattia
Copy link
Contributor

@nmattia nmattia commented Mar 11, 2025

This removes usages of ic_test_utilities::load_wasm from the ledger_suite_orchestrator test utils.

The load_wasm helper was introduced when both cargo & bazel tests were supported; now it merely adds indirection so we remove it. This also makes navigating the code & dependencies much easier as environment variables are referenced by named, instead of inferred from canister name.

This removes usages of `ic_test_utilities::load_wasm` from the
`ledger_suite_orchestrator` test utils.

The `load_wasm` helper was introduced when both cargo & bazel tests were
supported; now it merely adds indirection so we remove it. This also
makes navigating the code & dependencies much easier as environment
variables are referenced by named, instead of inferred from canister
name.
@github-actions github-actions bot added the chore label Mar 11, 2025
@nmattia nmattia marked this pull request as ready for review March 11, 2025 16:35
@nmattia nmattia requested a review from a team as a code owner March 11, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant