chore: add API BNs to release qualification tests #4310
+408
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-birkner
force-pushed
the
rjb/add-api-bn-to-qualification
branch
from
12cd2b4 to
12174fc
Compare
r-birkner
force-pushed
the
rjb/add-api-bn-to-qualification
branch
from
951b76c to
69f1b69
Compare
basvandijk
approved these changes
Mar 11, 2025
| ) -> anyhow::Result<()> { | ||
| let logger = env.logger(); | ||
|
|
||
| // check that there are even API boundary nodes |
There was a problem hiding this comment.
I would recommend changing all of the comments below into info!(logger, "...") calls such that it's easier to see what this test is doing by looking at the test output.
| .map(|n| n.node_id) | ||
| .collect(); | ||
|
|
||
| let proposal_id = rt.block_on(submit_update_api_boundary_node_version_proposal( |
There was a problem hiding this comment.
I would also add some logs per rt.block_on. That will help later when debugging in case this test times out in one of these operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the API boundary nodes to the release qualification tests. It adds two types of tests:
I ran the release qualification tests on this PR here.