feat: Add detailed memory usage metrics to CanisterStatusResultV2 #4106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced new memory metrics fields in `CanisterStatusResultV2`, including: - `wasm_memory_size` - `stable_memory_size` - `global_memory_size` - `wasm_binary_size` - `custom_sections_size` - `canister_history_size` - `wasm_chunk_store_size` - `snapshots_size` - Updated `CanisterManager` and `CanisterState` to compute and track these new metrics. - Refactored `ExecutionState` to provide individual methods for retrieving specific memory usage values. - Modified tests to validate the new memory metrics in canister status responses. This change improves visibility into canister memory consumption, aiding debugging and resource management. Refer to [PR portal#5240](dfinity/portal#5240) for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced new memory metrics fields in
CanisterStatusResultV2, including:wasm_memory_sizestable_memory_sizeglobal_memory_sizewasm_binary_sizecustom_sections_sizecanister_history_sizewasm_chunk_store_sizesnapshots_sizeUpdated
CanisterManagerandCanisterStateto compute and track these new metrics.Refactored
ExecutionStateto provide individual methods for retrieving specific memory usage values.Modified tests to validate the new memory metrics in canister status responses.
This change improves visibility into canister memory consumption, aiding debugging and resource management.
Refer to PR portal#5240 for more details.
Acknowledgements
This change was championed and implemented by @q-uint and @ByronBecker.