-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor candid ui auth #500
Conversation
There is not, unfortunately. |
@frederikrothenberger Would it work if we fetch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (suggested a fix for a subtle corner case).
Co-authored-by: Ryan Vandersmith <[email protected]>
cc @Web3NL |
Yes, you can parse that file. And if it contains the URL of the candid UI then you could set the canister base URL as a But this only works in a narrow scenario and should still be a user choice. Even better would be, to allow checking an arbitrary domain (i.e. a new input field) where you look up the asset |
Make sense. Users can still customize the derivation url with the |
ii
andorigin
. Report error on the login button if there is an error in the parameters.derivationOrigin
by default, unless in the mainnet and we can detect the destination canister has set candid UI to be the alternativeOrigin.