Skip to content

Use official github tool for creating release #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spoorcc merged 10 commits into from
Jan 4, 2026
Merged

Use official github tool for creating release #912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
288ae1f
Use official github tool
spoorcc Jan 4, 2026
d959df2
Use official gh release tool for uploading artifacts as well
spoorcc Jan 4, 2026
604e412
Make sure we have tag info when creating release
spoorcc Jan 4, 2026
8a9902c
--clobber should be last arg
spoorcc Jan 4, 2026
8425b70
Make sure gh release operates on correct repo
spoorcc Jan 4, 2026
6bf5dd3
Verify the tag
spoorcc Jan 4, 2026
c21fe06
Refresh just before creating release
spoorcc Jan 4, 2026
aedd139
Overwrite the local tag
spoorcc Jan 4, 2026
0440ffe
Setup python before checkout to not interfere with repo
spoorcc Jan 4, 2026
397fa28
No need to fetch tag etc, see comment
spoorcc Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 12 additions & 19 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,19 +102,17 @@ jobs:
build/dfetch-package/*.msi
build/dfetch-package/*.cdx.json

- name: Upload installer to release
- name: Upload installer to release ⬆️
if: ${{ inputs.release_id }}
uses: softprops/action-gh-release@5122b4edc95f85501a71628a57dc180a03ec7588 # v2.5.0
with:
tag_name: ${{ inputs.release_id }}
files: |
build/dfetch-package/*.deb
build/dfetch-package/*.rpm
build/dfetch-package/*.pkg
build/dfetch-package/*.msi
build/dfetch-package/*.cdx.json
draft: true
preserve_order: true
shell: bash
run: gh release upload \
"${{ inputs.release_id }}" \
build/dfetch-package/*.deb \
build/dfetch-package/*.rpm \
build/dfetch-package/*.pkg \
build/dfetch-package/*.msi \
build/dfetch-package/*.cdx.json \
--clobber
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Expand Down Expand Up @@ -213,12 +211,7 @@ jobs:
with:
name: python-package-distributions
path: dist/
- name: Upload artifacts to release
uses: softprops/action-gh-release@5122b4edc95f85501a71628a57dc180a03ec7588 # v2.5.0
with:
tag_name: ${{ inputs.release_id }}
files: dist/*
draft: true
preserve_order: true
- name: Upload artifacts to release ⬆️
run: gh release upload "${{ inputs.release_id }}" dist/* --clobber
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
23 changes: 14 additions & 9 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,13 @@ jobs:
- uses: step-security/harden-runner@20cf305ff2072d973412fa9b1e3a4f227bda3c76 # v2.14.0
with:
egress-policy: audit
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
- uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0
with:
python-version: '3.13'
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
with:
fetch-depth: 0
fetch-tags: true

- name: Determine release info
id: release_info
Expand Down Expand Up @@ -75,14 +78,16 @@ jobs:
echo "No release found for $TAG."
fi

- name: Create release
# Note that since this is a draft the link will be untagged (see https://github.com/cli/cli/issues/11589)
- name: Create draft release
if: ${{ steps.release_info.outputs.tag }}
uses: softprops/action-gh-release@5122b4edc95f85501a71628a57dc180a03ec7588 # v2.5.0
with:
tag_name: ${{ steps.release_info.outputs.tag }}
name: ${{ steps.release_info.outputs.tag }}
body_path: release_notes.txt
draft: true
files: LICENSE
run: |
gh release create "${{ steps.release_info.outputs.tag }}" \
--repo "$GITHUB_REPOSITORY" \
--title "${{ steps.release_info.outputs.tag }}" \
--notes-file release_notes.txt \
--draft \
--verify-tag \
LICENSE
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
Loading