implement crawling #936
Merged
implement crawling #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwistedAsylumMC
requested changes
Nov 16, 2024
server/block/cube/bbox.go
Outdated
| @@ -282,3 +282,26 @@ func (box BBox) ZOffset(nearby BBox, deltaZ float64) float64 { | |||
| } | |||
| return deltaZ | |||
| } | |||
|
|
|||
| // Corners returns slice of all hitbox corners | |||
There was a problem hiding this comment.
Please add a full stop at the end of this doc and the other 2 in this file.
server/block/cube/bbox.go
Outdated
Comment on lines
290
to
296
| xyZ := mgl64.Vec3{min[0], min[1], max[2]} | ||
| xYz := mgl64.Vec3{min[0], max[1], min[2]} | ||
| xYZ := mgl64.Vec3{min[0], max[1], max[2]} | ||
| XYz := mgl64.Vec3{max[0], max[1], min[2]} | ||
| XyZ := mgl64.Vec3{max[0], min[1], max[2]} | ||
| Xyz := mgl64.Vec3{max[0], min[1], min[2]} | ||
| return []mgl64.Vec3{min, max, xyZ, xYz, xYZ, XYz, XyZ, Xyz} |
There was a problem hiding this comment.
I'd remove these variables and do something like this:
return []mgl64.Vec3{
{min[0], min[1], max[2]},
{min[0], max[1], min[2]},
// etc.
}```
server/player/player.go
Outdated
Comment on lines
1050
to
1060
| var isAir bool | ||
| for _, corner := range p.Type().BBox(p).Translate(p.Position()).Corners() { | ||
| _, isAir = p.World().Block(cube.PosFromVec3(corner).Add(cube.Pos{0, 1, 0})).(block.Air) | ||
| if !isAir { | ||
| break | ||
| } | ||
| } | ||
|
|
||
| if !isAir && !p.crawling.CompareAndSwap(false, true) { | ||
| return | ||
| } |
There was a problem hiding this comment.
This can be slightly simplified to
for _, corner := range p.Type().BBox(p).Translate(p.Position()).Corners() {
_, isAir = p.World().Block(cube.PosFromVec3(corner).Add(cube.Pos{0, 1, 0})).(block.Air)
if !isAir {
if !p.crawling.CompareAndSwap(false, true) {
return
}
break
}
}
server/player/player.go
Outdated
Comment on lines
2656
to
2632
| default: | ||
| return 1.62 | ||
| } | ||
| return 1.62 |
There was a problem hiding this comment.
No point changing this to a default cause, keep how it was before
server/player/player.go
Outdated
Comment on lines
2618
to
2649
| // EyeHeight returns the eye height of the player: 1.62, or 0.52 if the player is swimming. | ||
| // EyeHeight returns the eye height of the player. |
There was a problem hiding this comment.
Could keep the last part of the doc and say "0.52 if the player is crawling or swimming, 1.26 when sneaking or 1.62 when standing."
TwistedAsylumMC
requested changes
Nov 16, 2024
server/block/cube/bbox.go
Outdated
| return BBox{min: box.min.Mul(val), max: box.max.Mul(val)} | ||
| } | ||
|
|
||
| // Volume calculates Volume of the BBox. |
There was a problem hiding this comment.
Little nitpick, second "Volume" makes more sense to be "the volume"
server/player/player.go
Outdated
| @@ -2617,8 +2646,11 @@ func (p *Player) OnGround() bool { | |||
|
|
|||
| // EyeHeight returns the eye height of the player: 1.62, or 0.52 if the player is swimming. | |||
There was a problem hiding this comment.
Would be nice if you could update this doc as previously mentioned to describe all states
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.