Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from df-mc/atomic to sync/atomic #915

Merged
merged 3 commits into from
Sep 2, 2024
Merged

Conversation

TwistedAsylumMC
Copy link
Member

df-mc/atomic was forked with the release of generics to add atomic.Value[T], and since Go 1.19 everything we used uber-go/atomic for has since been implemented in some form in sync/atomic. This PR removes the df-mc/atomic dependency and that repo will be archived when this is merged.

Copy link
Member

@Sandertv Sandertv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Feel free to merge if you've just ran dragonfly once and all seems good.

@TwistedAsylumMC TwistedAsylumMC merged commit d83eda4 into master Sep 2, 2024
4 checks passed
@TwistedAsylumMC TwistedAsylumMC deleted the feature/std-atomic branch September 2, 2024 10:09
@TwistedAsylumMC TwistedAsylumMC restored the feature/std-atomic branch September 2, 2024 10:09
@DaPigGuy DaPigGuy deleted the feature/std-atomic branch September 9, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants