Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entity_metadata.go: Fix incorrectly enconding of packedEffects #910

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

IvanCraft623
Copy link
Contributor

@IvanCraft623 IvanCraft623 commented Aug 10, 2024

The implementation has the following problems:

  • Does not include ambient indicator
  • Only the first two effects are correctly packed
    • This is caused because for some reason you are multiplying the shift 7 by the index. (wtf??).
      • On the first iteration nothing happened because it gave a bit shift of 0, as it is the first iteration it does not matter if there is bit shift or not.
      • On the second iteration 7 * 1, the shift is correct, Ok
      • From the third iteration on, the shifts are incorrect.

I almost had a stroke with the go syntax

@TwistedAsylumMC TwistedAsylumMC merged commit 44ad96b into df-mc:master Aug 15, 2024
1 check passed
@TwistedAsylumMC
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants