MERGE ALL THE FEATURES INTO MASTER #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TargetRubyVersion config in ruby has gone some heavy overhaul since it was first introduced in rubocop 0.36.0, and now there is a target_ruby_version method available directly from the RuboCop::Config class as of 0.41.0. This makes implementation added here redundant for newer versions of RuboCop, and also causes the tests to fail when resolving the TargetRubyVersion through it. It shall be used for rubocop versions less than 0.41.0 until those are not supported, but on anything greater than that, we shall call out to the RuboCop::Config API directly for resolution of that (it will use RuboCop::Config::DEFAULT_RUBY_VERSION if it is not able to determine one, avoiding errors).
In rubocop 0.47.0, the `RuboCop::Cop::Registry` was added as the new way of handling passing around a collection of Cops to other portions of the code base. See rubocop/rubocop#3837 This change, as a result, made it so that initializing `RuboCop::Cop::Team` required you passing in a `Registry`, and not an Array of cops (which was previously supported`. Because this change is not backwards compatible, we need to support two ways of intializing the `RuboCop::Cop::Team`: 1. By passing it an array of cops: `RuboCop::Cop::Cop.all` 2. By passing it a registry of cops: `RuboCop::Cop::Registry.new cops` And this is dependent on the version, so the `all_cops` methods will be conditionally created based on the VERSION of rubocop that supports either call.
…x-to-default Reset git diff settings for color and mnemonicprefix to default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so we maintain our own fork. We can just use master rather than dealing with custom branches.
I need this, so I don't need to manually patch
rubocop-gitwithbundle open rubocop-gitevery time I update a gem.