Allow gracePeriod and onError options to useDocument() #2188
+36
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merging this PR, release a new dexie-react-hooks package and document the new options.
This PR was mainly done to allow attaching an error handler to the DexieYProvider in case writing updates failed for any reason.
However, failing to write updates to dexie should probably be catched globally and not on every single component, since this could be due to quota limit exceeded or instable indexedDB.
So, think also about a solution to catch these types of errors globally. This is not dedicated to Y.js but rather working around indexedDB stability issues for an application. For example, the application might need to show a big warning message that it isn't able to store data. Use StorageManager API to show the quota left and advice user to take action, such as clearing storage.