feat: add Sifi #31
Open
feat: add Sifi #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't find much information about your aggregator. Has it undergone an audit? At this time, we may not feel comfortable merging it into production. Thank you! |
Thanks for reviewing so quickly, @sneg55. I completely understand you want to see audits and some social proof before merging. We're in the process of picking auditors now. Can you recommend some that you trust? For the social proof, do you have any tips? Sifi is new, we're a really dedicated team and ready to put in the work to build trust. Feel free to mark this PR as a draft for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the multi-chain DEX aggregator Sifi
Testing
Swaps between various tokens, including ETH, have been tested on Ethereum and Arbitrum.
Future work
Cross-chain will be added in a future PR.