Merge pull request #2039 from devtron-labs/fix/cd-pipeline

chore: fix security modal scroll height
devtron-labs · Sep 10, 2024 · 42fa277 · 42fa277
2 parents 7935169 + 4f58fef
commit 42fa277
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/components/common/security/ScanDetailsModal.tsx b/src/components/common/security/ScanDetailsModal.tsx
@@ -218,18 +218,18 @@ export class ScanDetailsModal extends Component<ScanDetailsModalProps, ScanDetai
                 >
                     {this.renderHeader()}
                     {this.renderAppEnvInfo()}
-                    <div className="trigger-modal__body trigger-modal__body--security-scan">
+                    <div className="flexbox-col dc__overflow-auto p-0 bcn-0 trigger-modal__body--security-scan">
                         {this.state.view === ViewType.LOADING ? (
                             <Progressing pageLoader />
                         ) : this.state.view === ViewType.ERROR ? (
                             <Reload reload={this.callGetAPI} />
                         ) : this.state.view === ViewType.FORM && this.state.vulnerabilities.length === 0 ? (
                             <NoVulnerabilityViewWithTool scanToolId={this.state.scanToolId} />
                         ) : (
-                            <div className="trigger-modal__body trigger-modal__body--security-scan">
+                            <>
                                 {this.renderScannedObjectInfo()}
                                 {this.renderTable()}
-                            </div>
+                            </>
                         )}
                     </div>
                 </div>

diff --git a/src/components/security/security.scss b/src/components/security/security.scss
@@ -368,8 +368,7 @@
     }
 
     .trigger-modal__body--security-scan {
-        background-color: var(--N000);
-        padding: 0;
+        height: calc(100vh - 87px);
     }
 
     .vulnerability-exp__form {