feat(localRegistry): expose pod resources#2964
feat(localRegistry): expose pod resources#2964Milias wants to merge 8 commits intodevspace-sh:mainfrom
Conversation
✅ Deploy Preview for devspace-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bumps [@babel/runtime-corejs3](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime-corejs3) from 7.22.5 to 7.26.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-runtime-corejs3) --- updated-dependencies: - dependency-name: "@babel/runtime-corejs3" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Francisco Garcia Florez <francisco@truevoid.dev>
Signed-off-by: Francisco Garcia Florez <francisco@truevoid.dev>
Signed-off-by: Francisco Garcia Florez <francisco@truevoid.dev>
Milias
force-pushed
the
add-local-registry-resources
branch
from
e59a093 to
4102245
Compare
Signed-off-by: Francisco Garcia Florez <francisco@truevoid.dev>
Signed-off-by: Francisco Garcia Florez <francisco@truevoid.dev>
Signed-off-by: Francisco Garcia Florez <francisco@truevoid.dev>
Milias
changed the title
|
Before we review, would you mind looking at the errors from the failed check for Lint? https://github.com/devspace-sh/devspace/actions/runs/15261087358/job/43202271440?pr=2964 |
Signed-off-by: Francisco Garcia Florez <francisco@truevoid.dev>
Milias
force-pushed
the
add-local-registry-resources
branch
from
30e1bc1 to
9fc56c1
Compare
Thanks for the heads up! I removed those two unused fields, I had to guess a bit because I couldn't easily run the linter locally. Hopefully that was all :) |
|
Hello! I don't know exactly why there is a failing test, doesn't seem related to changes in the PR. Is there something I could do? |
It looks like this was a temporary failure. Could you also rebase your branch against |
|
Done! Let's see if pipelines collaborate :) |
3 participants
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)No issue.
Please provide a short message that should be published in the DevSpace release notes
Exposed in the
localRegistryconfiguration resources and annotations of the created Pods.What else do we need to know?
I am not very familiar with go or this codebase, if you have any suggestions please feel free!