shard-manager: only allow alive pods to register #146
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a pod that is not healthy can still be registered to shard-manager, but will be deregistered immediately following a healthcheck. This is not desirable as it can cause rapid rebalancing of many shards, and in the worst case, service disruption when the api pods do not get the unassignment notification.
This PR aims to prevent this by not allowing assignment of shards when the shard manager does not find the pod healthy.
Background:
As discussed here: https://discord.com/channels/629491597070827530/1017210544295522325/1296046997601652799