Skip to content

Conversation

toshywoshy
Copy link
Contributor

see London, Halifax and Istanbul logo on the main page it gets cut off
using resize it should resize the image better
and avoid any cutting off

For ease of understanding adding before and after screenshots
Before/Current : using the fill
2025-04-05_00-11-1743804687
After/Improvement : using resize
2025-04-05_00-11-1743804686

see london logo on the main page it gets cut off
using resize it should resize the image better
and avoid any cutting off

Signed-off-by: Toshaan Bharvani <[email protected]>
@toshywoshy toshywoshy requested a review from a team as a code owner April 4, 2025 22:19
Copy link

netlify bot commented Apr 4, 2025

Deploy Preview for devopsdays-web ready!

Name Link
🔨 Latest commit 9c36d69
🔍 Latest deploy log https://app.netlify.com/sites/devopsdays-web/deploys/67fe3b407b94960008d758ea
😎 Deploy Preview https://deploy-preview-15058--devopsdays-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jerdog jerdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mattstratton mattstratton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine. There might be some weirdness for logos being squished but I think the code allows for a separate logo for the shortcode (for use on welcome page) than for the main screen as an override

@toshywoshy toshywoshy merged commit 0b93f2f into devopsdays:main Apr 15, 2025
8 checks passed
@toshywoshy toshywoshy deleted the fill2resize branch May 15, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants