Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Commit

Permalink
Bump node version to 18
Browse files Browse the repository at this point in the history
Version 16 will be end of life in September.

Ref: https://endoflife.date/nodejs
  • Loading branch information
scottmuc committed Apr 18, 2023
1 parent aeeb773 commit f6a749e
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/continuous-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
- uses: actions/checkout@master
- uses: actions/setup-node@v1
with:
node-version: 16
node-version: 18
- run: npm run-script build
- uses: superfly/flyctl-actions/setup-flyctl@master
- run: flyctl deploy --remote-only
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pull-request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ jobs:
- uses: actions/checkout@master
- uses: actions/setup-node@v1
with:
node-version: 16
node-version: 18
- run: npm run-script build
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
nodejs 16.19.0
nodejs 18.16.0
flyctl 0.0.456
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
FROM debian:bullseye as builder

ARG NODE_VERSION=v16.18.1
ARG NODE_VERSION=v18.16.0

RUN apt-get update; apt install -y curl python3 build-essential
RUN curl https://get.volta.sh | bash
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Refer to [CONTRIBUTING.md][contributing_url]
## Development

* Have a working `docker` setup and this repository clone
* `docker run --rm -it -v $PWD:/workspace -p 8080:8080 -w /workspace node:16 bash`
* `docker run --rm -it -v $PWD:/workspace -p 8080:8080 -w /workspace node:18 bash`
* Running `npm run-script build` and then `npm start`
* Look at the results in your browser: `open http://localhost:8080/`

Expand Down
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"heroku-postbuild": "script/build"
},
"engines": {
"node": "16.x"
"node": "18.x"
},
"dependencies": {
"bourbon": "latest",
Expand Down

0 comments on commit f6a749e

Please sign in to comment.