Skip to content

Conversation

sob
Copy link

@sob sob commented Feb 4, 2025

No description provided.

@Fuochi
Copy link
Collaborator

Fuochi commented Feb 6, 2025

Hi @sob,
Thanks for the contribution, I'll have a look at this once we release the new sdk version.

Copy link
Collaborator

@Fuochi Fuochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally speaking. I'd keep the second commit as it is, while I would like to be consistent with the other providers.
If you don't mind, you can change only the api case, and leave the pointer up to me.
Also, please use conventional commit.

Comment on lines +126 to +132
pointerResponse := make([]*readarr.CustomFormatResource, len(response))
for i := range response {
pointerResponse[i] = &response[i]
}

formats := make([]CustomFormat, len(pointerResponse))
for i, p := range pointerResponse {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to align this provider's code with the other ones instead of doing this. Do you mind changing only the API case in this commit? I'll then add few commits to align with the other providers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants