Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue with JSON renderer #281

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes issue with JSON renderer #281

wants to merge 2 commits into from

Conversation

djschleen
Copy link
Member

A previous contribution changed the default JSON renderer that wrote to STDOUT for chaining. A new output type called json-file will output a JSON file to the filesystem.

@djschleen djschleen requested a review from mirxcle January 6, 2025 21:07
@djschleen djschleen self-assigned this Jan 6, 2025
@djschleen djschleen added bug Something isn't working enhancement New feature or request labels Jan 6, 2025 — with GitHub Codespaces
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 35.29412% with 11 lines in your changes missing coverage. Please review.

Project coverage is 66.37%. Comparing base (692b3e4) to head (1320f51).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
renderers/jsonfile/jsonfile.go 0.00% 7 Missing ⚠️
renderers/json/json.go 40.00% 2 Missing and 1 partial ⚠️
cmd/root.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #281      +/-   ##
==========================================
+ Coverage   65.81%   66.37%   +0.55%     
==========================================
  Files          28       29       +1     
  Lines        1562     1579      +17     
==========================================
+ Hits         1028     1048      +20     
+ Misses        504      500       -4     
- Partials       30       31       +1     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

1 participant