Skip to content

#1965: improve dependent installation (WIP)#2169

Open
MeShehi wants to merge 1 commit into
devonfw:mainfrom
MeShehi:1965_improve_dependent
Open

#1965: improve dependent installation (WIP)#2169
MeShehi wants to merge 1 commit into
devonfw:mainfrom
MeShehi:1965_improve_dependent

Conversation

@MeShehi

@MeShehi MeShehi commented Jul 17, 2026

Copy link
Copy Markdown

This PR fixes #1965 (WIP)

Implemented changes:

  • Added InstallRequest in PackageManagerRequest which acts as installation context enabling loop checks on PackageManagerBasedLocalToolCommandlet

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:


Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

Checklist for tool commandlets

Have you added a new «tool» as commandlet? There are the following additional checks:

  • The tool can be installed automatically (during setup via settings) or via the commandlet call
  • The tool is isolated in its IDEasy project, see Sandbox Principle
  • The new tool is added to the table of tools in LICENSE.asciidoc
  • The new commandlet is a command-wrapper for «tool»
  • Proper help texts for all supported languages are added here
  • The new commandlet installs potential dependencies automatically
  • The variables «TOOL»_VERSION and «TOOL»_EDITION are honored by your commandlet
  • The new commandlet is tested on all platforms it is available for or tested on all platforms that are in scope of the linked issue

@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 29562456972

Coverage decreased (-0.02%) to 72.486%

Details

  • Coverage decreased (-0.02%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 11 coverage regressions across 3 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

11 previously-covered lines in 3 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/tool/PackageManagerRequest.java 5 77.78%
com/devonfw/tools/ide/tool/PackageManagerBasedLocalToolCommandlet.java 4 91.21%
com/devonfw/tools/ide/version/VersionSegment.java 2 89.5%

Coverage Stats

Coverage Status
Relevant Lines: 16808
Covered Lines: 12705
Line Coverage: 75.59%
Relevant Branches: 7500
Covered Branches: 4915
Branch Coverage: 65.53%
Branches in Coverage %: Yes
Coverage Strength: 3.19 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🆕 New

Development

Successfully merging this pull request may close these issues.

Improve dependent installations

2 participants