#2131: improve auto completion for ide upgrade mode#2164
Open
vivu001 wants to merge 10 commits into
Open
Conversation
Add enum value completion for `ide upgrade --mode` and keep the implementation local to `UpgradeModeProperty`.
Preserve `--mode=` in shell completion so `ide upgrade --mode` can offer enum value suggestions correctly.
Collaborator
Coverage Report for CI Build 29497379560Coverage increased (+0.001%) to 72.507%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions2 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
oanding-blrng
approved these changes
Jul 15, 2026
| This can cause that the auto-completion of versions can take a few seconds sometimes. | ||
| However, we implemented a smart caching mechanism so we do not call `git pull` again if already done a minute ago. | ||
|
|
||
| The auto-completion also supports argument values. |
Contributor
There was a problem hiding this comment.
As someone reading this for the first time, I would assume, that argument values are supported everywhere within ide .... If this is in fact true, it's fine.
In case, there are still places, auto-completion for argument values are not implemented yet, this could cause confusion or bug reports and should be changed.
Contributor
Author
There was a problem hiding this comment.
Agreed 😃. I’ll refine the wording slightly so it’s less likely to be misinterpreted.
Contributor
|
Please also change the title of this PR to follow the rules of DoD:
|
…ch, and no-match behavior of upgrade mode completion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR fixes #2131
Implemented changes:
EnumProperty--modeinUpgradeCommandlet--mode=s)--key=value)Testing instructions
Ensure the newly built executable is picked up (restart shell if needed).
Expected output:
--mode=snapshot --mode=stable --mode=unstableThe suggested values correspond to all predefined values of the UpgradeMode enum.
Expected output:
--mode=snapshot --mode=stableExpected output: the command is automatically completed with the matched value.
ide upgrade --mode=stableChecklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal