Skip to content

#2056 Replaced progress bar with progress information for plugin installation#2105

Merged
hohwille merged 13 commits into
devonfw:mainfrom
oanding-blrng:feature/2056-remove-progress-bar-for-vscode-plugins
Jul 17, 2026
Merged

#2056 Replaced progress bar with progress information for plugin installation#2105
hohwille merged 13 commits into
devonfw:mainfrom
oanding-blrng:feature/2056-remove-progress-bar-for-vscode-plugins

Conversation

@oanding-blrng

@oanding-blrng oanding-blrng commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR fixes #2056

Implemented changes:

  • Removed custom implementation for VSCode for installing plugins and therefore progress bar for installing wont appear anymore
  • Added a general progress marker (e.g. (N/M)) in default implementation for installing plugins in PluginBasedCommandlet (progress marker should be visible also for installing plugins in other plugin based IDEs, if plugins are setup in settings
  • Modified expected log output in tests for AndroidStudio, Eclipse, IntelliJ Idea, PyCharm and PluginBasedCommandlet and VSCode

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

  1. Uninstall VSCode with ide uninstall vscode to force installation
  2. Create run configuration in IntelliJ for ide-cli module
  3. Let the working directory point to the current ide project
  4. Add vscode or install vscode as the program argument
  5. Execute run configuration

Retesting after Merge

  1. Uninstall VSCode with ide uninstall vscode to force installation
  2. Run ide vscode or ide install vscode

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

@oanding-blrng
devonfw#2056 Removed progressbar for vscode plugin installations
409f2b0 
* Removed custom implementation of installPlugins() with progressbar in Vscode.java
* Modified name of stop with progress marker "(n/m)" in installPlugins() in PluginBasedCommandlet.java.
@oanding-blrng
devonfw#2056 Modified installPlugins to only increment counter for ac…
4f51393 
…tive plugins and also use the total amount of active plugins instead of all.
@oanding-blrng
devonfw#2056 Modified expected log entries for installing plugins.
7f2ff4e
@oanding-blrng
devonfw#2056 Moved creation of progress marker into own line.
d728606
@oanding-blrng
Merge branch 'main' into feature/2056-remove-progress-bar-for-vscode-…
234d29c 
…plugins
@oanding-blrng
devonfw#2056 Added ticket to CHANGELOG.adoc
23a5245
@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board Jul 3, 2026
@oanding-blrng oanding-blrng self-assigned this Jul 3, 2026
@oanding-blrng oanding-blrng added enhancement New feature or request vscode Microsoft visual studio code plugins related to plugins (for Eclipse, Intellij, VSCode, etc.) logging IDEasy specific logging (levels, messages, etc.) step Logging and monitoring of process steps labels Jul 3, 2026
@oanding-blrng oanding-blrng moved this from 🆕 New to 🏗 In progress in IDEasy board Jul 3, 2026
@coveralls

coveralls commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 29607429678

Coverage decreased (-0.07%) to 72.432%

Details

  • Coverage decreased (-0.07%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 26 coverage regressions across 8 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

26 previously-covered lines in 8 files lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/tool/plugin/PluginBasedCommandlet.java 10 86.63%
com/devonfw/tools/ide/process/ProcessContextImpl.java 5 78.98%
com/devonfw/tools/ide/tool/vscode/Vscode.java 4 86.67%
com/devonfw/tools/ide/context/IdeContext.java 3 75.4%
com/devonfw/tools/ide/log/IdeLogLevel.java 1 78.3%
com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java 1 78.33%
com/devonfw/tools/ide/url/model/AbstractUrlArtifact.java 1 85.71%
com/devonfw/tools/ide/version/VersionSegment.java 1 90.55%

Coverage Stats

Coverage Status
Relevant Lines: 16791
Covered Lines: 12680
Line Coverage: 75.52%
Relevant Branches: 7494
Covered Branches: 4910
Branch Coverage: 65.52%
Branches in Coverage %: Yes
Coverage Strength: 3.19 hits per line
💛 - Coveralls

@oanding-blrng
oanding-blrng marked this pull request as ready for review July 3, 2026 12:21
@oanding-blrng oanding-blrng moved this from 🏗 In progress to Team Review in IDEasy board Jul 3, 2026
@Caylipp

Caylipp commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Good Job on the Implementation.
I tested it successfully.
image
Plugin installation now shows progress information instead of the progress bar. Works as expected.
Looks good to me!

@Caylipp Caylipp moved this from Team Review to 👀 In review in IDEasy board Jul 9, 2026
hohwille
hohwille approved these changes Jul 17, 2026
View reviewed changes

@hohwille hohwille left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oanding-blrng thanks for your PR. All solved perfectly correct and new feature works out as planned. Great job 👍
BTW: sorry for the late response.
For the record, in the tests you could have also changed from hasMessage to hasNoMessageContaining so we do not depend on the plugin count and tests are less likely to break on small changes of the test project structure. However, I also like your exact assertion to make the feature explicit. Since we dropped for overloading the basic project and have dedicated test projects per commandlet or use-case this should be stable enough and is even better this way.
I will move the CHANGELOG entry up to the current release and then merge.

@hohwille hohwille added this to the release:2026.07.002 milestone Jul 17, 2026
@hohwille
hohwille merged commit 1389cc2 into devonfw:main Jul 17, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in IDEasy board Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hohwille hohwille hohwille approved these changes

Assignees

@Caylipp Caylipp

@oanding-blrng oanding-blrng

Labels

enhancement New feature or request logging IDEasy specific logging (levels, messages, etc.) plugins related to plugins (for Eclipse, Intellij, VSCode, etc.) step Logging and monitoring of process steps vscode Microsoft visual studio code

Projects

IDEasy board
Status: ✅ Done

Milestone

release:2026.07.002

Development

Successfully merging this pull request may close these issues.

Remove progress bar for vscode plugins

5 participants

@oanding-blrng @coveralls @Caylipp @hohwille @maybeec