Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/relantionship init #25

Merged
merged 7 commits into from
Apr 16, 2016
Merged

Feature/relantionship init #25

merged 7 commits into from
Apr 16, 2016

Conversation

MP0w
Copy link
Member

@MP0w MP0w commented Apr 14, 2016

Closes #12

@MP0w
Copy link
Member Author

MP0w commented Apr 14, 2016 •
edited
Loading

  • Add test for create inside create / insert inside insert
  • Fix deadlock for create inside create

@MP0w
Copy link
Member Author

MP0w commented Apr 14, 2016

Same deadlock for all the synchronous stuff: e.g. find inside a create

joanromano
joanromano reviewed Apr 16, 2016
View reviewed changes
Source/KakapoDB.swift
if dispatch_get_specific(queueKey) == queueContext {
closure()
} else {
dispatch_barrier_sync(queue, closure)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be async now?

@joanromano
Copy link
Member

👍

@MP0w MP0w merged commit 7a2996c into master Apr 16, 2016
@MP0w MP0w deleted the feature/relantionshipInit branch April 16, 2016 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MP0w @joanromano @zzarcon