Skip to content

coreinit/thread: OSThreadEntryPointFn and OSCreateThread take void* for arg #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
capitalistspz wants to merge 2 commits into
base: master
Choose a base branch
from
Open

coreinit/thread: OSThreadEntryPointFn and OSCreateThread take void* for arg #421

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcdcd2e
`OSThreadEntryPointFn` and `OSCreateThread` take `void*` for arg
capitalistspz May 24, 2025
5ad6ed4
Change arg for `crash.c`
capitalistspz May 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions include/coreinit/thread.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ typedef uint8_t OSThreadAttributes;
//! A bitfield of enum OS_THREAD_TYPE.
typedef uint32_t OSThreadType;

typedef int (*OSThreadEntryPointFn)(int argc, const char **argv);
typedef int (*OSThreadEntryPointFn)(int argc, void *argv);
typedef void (*OSThreadCleanupCallbackFn)(OSThread *thread, void *stack);
typedef void (*OSThreadDeallocatorFn)(OSThread *thread, void *stack);

Expand Down Expand Up @@ -433,7 +433,7 @@ BOOL
OSCreateThread(OSThread *thread,
OSThreadEntryPointFn entry,
int32_t argc,
char *argv,
void *argv,
void *stack,
uint32_t stackSize,
int32_t priority,
Expand Down
2 changes: 1 addition & 1 deletion libraries/libwhb/src/crash.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ static OSThread __attribute__((aligned(8)))
sCrashThread;

static int
crashReportThread(int argc, const char **argv)
crashReportThread(int argc, void* argv)
{
// Log crash dump
WHBLogPrint(sRegistersBuffer);
Expand Down