compiler: Enhance IR to support more advanced parlang (CUDA/HIP/SYCL) features #2748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2748 +/- ##
==========================================
- Coverage 83.05% 82.55% -0.51%
==========================================
Files 248 248
Lines 50294 50379 +85
Branches 4426 4431 +5
==========================================
- Hits 41773 41589 -184
- Misses 7763 8019 +256
- Partials 758 771 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mloubout
reviewed
Oct 1, 2025
| initvalue = tuple(i.subs(subs_user) for i in k) | ||
| w = weights[k] = w0._rebuild(name=name, dtype=dtype, initvalue=initvalue) | ||
|
|
||
| rebuilt = expr._subs(w0.indexed, w.indexed) |
There was a problem hiding this comment.
why not just expr._rebuild(weights=w)?
mloubout
approved these changes
Oct 1, 2025
EdCaunt
reviewed
Oct 2, 2025
| def __hash__(self): | ||
| return hash((super().__hash__(), self.sub_iterators, | ||
| self.directions)) | ||
| return hash((super().__hash__(), self.sub_iterators, self.directions)) |
There was a problem hiding this comment.
Would having a hashable items attribute like we use in some other classes clean this up a little?
|
|
||
| """ | ||
| Abstract base class for all terminal objects, that is, those objects | ||
| collected by `retrieve_terminals` in addition to all other SymPy atoms |
There was a problem hiding this comment.
This is a somewhat tautologous definition. What conceptually is a "terminal" here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #2717