Skip to content

Conversation

ziyiyin97
Copy link
Contributor

No description provided.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@mloubout mloubout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well no that fix should go directly into the Rocker definition so that it's always correct by default.

@ziyiyin97 ziyiyin97 changed the title docs: fix elastic tutorial examples: Fix DC component in Ricker source Sep 23, 2025
@ziyiyin97 ziyiyin97 requested a review from mloubout September 23, 2025 18:57
@mloubout mloubout added the examples examples label Sep 23, 2025
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.77%. Comparing base (fd6a755) to head (c6e66f1).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2743      +/-   ##
==========================================
- Coverage   83.05%   78.77%   -4.29%     
==========================================
  Files         248      248              
  Lines       50438    50439       +1     
  Branches     4437     4437              
==========================================
- Hits        41893    39735    -2158     
- Misses       7785     9891    +2106     
- Partials      760      813      +53     
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX ?
pytest-gpu-nvc-nvidiaX ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ziyiyin97
Copy link
Contributor Author

Forcing the Ricker source to be zero-mean will lead to resampling failures. I guess we can make zero_mean an option and make it false for the resampling test. Please advise. Thanks!

@mloubout
Copy link
Contributor

What do you mean resampling failures ?

@ziyiyin97
Copy link
Contributor Author

The test_resample.py failed

@mloubout
Copy link
Contributor

mloubout commented Oct 2, 2025

Right because the mean correction gonna be slightly different. I would probably just patc the test adding some tolerance rather than adding an extra argument

@ziyiyin97 ziyiyin97 force-pushed the master branch 2 times, most recently from 05b8148 to 8913c3e Compare October 2, 2025 19:02
@ziyiyin97
Copy link
Contributor Author

Yes I raised the tolerance of the resampling test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants