-
Notifications
You must be signed in to change notification settings - Fork 240
examples: Fix DC component in Ricker source #2743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well no that fix should go directly into the Rocker definition so that it's always correct by default.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2743 +/- ##
==========================================
- Coverage 83.05% 78.77% -4.29%
==========================================
Files 248 248
Lines 50438 50439 +1
Branches 4437 4437
==========================================
- Hits 41893 39735 -2158
- Misses 7785 9891 +2106
- Partials 760 813 +53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Forcing the Ricker source to be zero-mean will lead to resampling failures. I guess we can make |
What do you mean resampling failures ? |
The test_resample.py failed |
Right because the mean correction gonna be slightly different. I would probably just patc the test adding some tolerance rather than adding an extra argument |
05b8148
to
8913c3e
Compare
Yes I raised the tolerance of the resampling test. |
No description provided.