Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: nats (original, plain) #2343

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

joeriddles
Copy link

@joeriddles joeriddles commented Jan 27, 2025

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes #1996

Link to prove your SVG is correct and up-to-date.

@joeriddles joeriddles marked this pull request as ready for review January 27, 2025 22:24
@joeriddles joeriddles changed the title new icon: NATS new icon: nats Jan 28, 2025
@joeriddles joeriddles changed the title new icon: nats new icon: nats (original, plain) Jan 28, 2025
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great work. Just a few comments about the scaling and color of the plain svg.

icons/nats/nats-plain.svg Show resolved Hide resolved
icons/nats/nats-original.svg Show resolved Hide resolved
@joeriddles
Copy link
Author

Overall great work. Just a few comments about the scaling and color of the plain svg.

@canaleal Thanks for the review! Just pushed an update with the SVGs updated to reach the edge of the fillbox. Note: the icon is not square, it is a rectangle whose longest dimension is the height. The Y dimension reached the edge of the fillbox, but the X dimension does not.

Also updated the plain icon color to match the primary color in devicon.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ICON REQUEST]: NATS
2 participants