Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use objc2-core-bluetooth #389

Merged
merged 4 commits into from
Jun 1, 2024
Merged

Conversation

madsmtm
Copy link
Contributor

@madsmtm madsmtm commented Jun 1, 2024

Continuing from #381, I've created the objc2-core-bluetooth crate, so let's use that to avoid having to define the methods ourselves.

Also, we now use objc2's declare_class! macro for the custom delegate, this is a lot less error-prone that using ClassBuilder. This part was done in two commits to hopefully make the diff easier to read.

@qdot
Copy link
Contributor

qdot commented Jun 1, 2024

Wow, this is much cleaner than what we had! Thanks!

@qdot qdot merged commit d6d54d4 into deviceplug:dev Jun 1, 2024
4 checks passed
@madsmtm madsmtm deleted the objc2-core-bluetooth branch June 1, 2024 17:41
@szymonlesisz szymonlesisz mentioned this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants