fix: abort setup when no WiFi-connected fireplaces found#60
Merged
deviantintegral merged 2 commits intomainfrom Mar 20, 2026
Merged
fix: abort setup when no WiFi-connected fireplaces found#60deviantintegral merged 2 commits intomainfrom
deviantintegral merged 2 commits intomainfrom
Conversation
During initial config flow setup, after successful authentication, verify that at least one fireplace has a valid WiFi overview before creating the config entry. If none are found, abort with a user-friendly message explaining that their fireplace may be Bluetooth-only. Also adds defensive TypeError/KeyError handling in the coordinator's _async_update_data() to gracefully skip fires whose WifiFireOverview is null in the API response. Closes #55 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…andling - New test_validate_fireplaces.py: tests for the validate_fireplaces validator covering success, no fires, all-Bluetooth (TypeError/KeyError), mixed WiFi+Bluetooth, and early-return short-circuit cases - Config flow tests: abort on no WiFi fireplaces, connection errors during fireplace check, updated happy path to mock _validate_fireplaces - Coordinator tests: TypeError and KeyError handling in _async_update_data Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
Author
|
Static review looks good to me. I'm not willing to reset my account to test the error cases right now, but given that those cases mean that the integration will never work anyways I'm OK with that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeError/KeyErrorhandling in the coordinator's_async_update_data()to gracefully skip fires with nullWifiFireOverviewCloses #55
Test plan
no_wifi_fireplacesmessageno_wifi_fireplacesmessage🤖 Generated with Claude Code