Skip to content

fix (backupcronjob): use non-cached client for registry auth Secret lookup #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rohanKanojia wants to merge 1 commit into from
+2 −2
Closed

fix (backupcronjob): use non-cached client for registry auth Secret lookup #1557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions controllers/backupcronjob/backupcronjob_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,7 @@ func (r *BackupCronJobReconciler) handleRegistryAuthSecret(ctx context.Context,

// First check the workspace namespace for the secret
registryAuthSecret := &corev1.Secret{}
err := r.Get(ctx, client.ObjectKey{
err := r.NonCachingClient.Get(ctx, client.ObjectKey{
Name: secretName,
Namespace: workspace.Namespace}, registryAuthSecret)
if err == nil {
Expand All @@ -488,7 +488,7 @@ func (r *BackupCronJobReconciler) handleRegistryAuthSecret(ctx context.Context,
log.Info("Registry auth secret not found in workspace namespace, checking operator namespace", "secretName", secretName)

// If the secret is not found in the workspace namespace, check the operator namespace as fallback
err = r.Get(ctx, client.ObjectKey{
err = r.NonCachingClient.Get(ctx, client.ObjectKey{
Name: secretName,
Namespace: dwOperatorConfig.Namespace}, registryAuthSecret)
if err != nil {
Expand Down
Loading