Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessing default connection for duckdb 1.2 #772

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Fix accessing default connection for duckdb 1.2 #772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lonboard/_geoarrow/_duckdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,14 @@ def _from_geometry(
SELECT ST_AsWKB( {geom_col_name} ) as {geom_col_name} FROM rel;
"""
try:
# duckdb.default_connection changed from attribute to callable in duckdb 1.2
default_con = (
duckdb.default_connection()
if callable(duckdb.default_connection)
else duckdb.default_connection
)
geom_table = Table.from_arrow(
duckdb.execute(sql, connection=duckdb.default_connection).arrow(),
duckdb.execute(sql, connection=default_con).arrow(),
)
except duckdb.CatalogException as err:
msg = (
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ docs = [
"black>=24.8.0",
]
dev = [
"duckdb>=1.1.3",
"duckdb>=1.2.0",
"fiona<1.10",
"geoarrow-pyarrow>=0.1.2",
"geoarrow-rust-core>=0.3.0",
Expand Down
Loading