Scope tailwind preflight styles #740
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bjoern-Rapp
changed the title
|
@Bjoern-Rapp this is working for me. I tested in vscode and it doesn't seem to be leaking styles anymore. Would you be able to run |
Bjoern-Rapp
force-pushed
the
scope-css
branch
from
f1845d6 to
32c1717
Compare
vgeorge
reviewed
Jan 31, 2025
Comment on lines
+2
to
+26
| color: #11181c; | ||
| color: hsl(var(--nextui-foreground)); | ||
| background-color: #fff; | ||
| background-color: hsl(var(--nextui-background)); | ||
| margin: 0; | ||
| line-height: 1.5; | ||
| -webkit-text-size-adjust: 100%; | ||
| tab-size: 4; | ||
| font-family: | ||
| ui-sans-serif, | ||
| system-ui, | ||
| -apple-system, | ||
| Segoe UI, | ||
| Roboto, | ||
| Ubuntu, | ||
| Cantarell, | ||
| Noto Sans, | ||
| sans-serif, | ||
| "Apple Color Emoji", | ||
| "Segoe UI Emoji", | ||
| Segoe UI Symbol, | ||
| "Noto Color Emoji"; | ||
| font-feature-settings: normal; | ||
| font-variation-settings: normal; | ||
| -webkit-tap-highlight-color: transparent; |
There was a problem hiding this comment.
@Bjoern-Rapp it didn't notice this when I reviewed yesterday. Could you explain why this was added?
There was a problem hiding this comment.
Some selectors in the preflight stylesheet targets html, body and :root elements. They become useless when scoped to the div.lonboard wrapper, since there are no html or body elements inside the wrapper. The only alternative then is to copy / duplicate those properties from the resulting stylesheet and apply them directly to the wrapper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anywidget loads CSS from the _css attribute to the global scope. A widget most take care not to conflict with any other CSS selectors. The stylesheet from the tailwind preflight, loaded with
@tailwind base, will conflict with stylesheets from Sphinx themes (#698) or the VScode interactive display (#696).To scope the preflight stylesheet to descendants of a wrapper should fix that.