You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
isomorphic-unfetch: Consider making node-fetch a peerDependency #143
I have the case where I'd like to have better control of the version of node-fetch used (v3.x beta). If it were a peer dependency I'd be able to do this.
Fully support this since unfetch bundles its own type definitions. Per @mindplay-dk's own comment in that thread,
But either way, it's currently an undeclared dependency - you have to get a build failure and then manually install the package, so I think either that should be fixed, or the dependency should be removed?
E: I wonder if you shouldn't open a separate issue for visibility.
Activity
developit commentedon Sep 29, 2020
Definitely open to this.
carlpaten commentedon Jun 29, 2021
Peer dependencies are not meant to be optional. This will cause problems with non-node installs.
mindplay-dk commentedon Aug 2, 2021
How about at least adding a peer dependency on
@types/node-fetch, so building with this package doesn't fail? (see #96)carlpaten commentedon Aug 2, 2021
Fully support this since
unfetchbundles its own type definitions. Per @mindplay-dk's own comment in that thread,E: I wonder if you shouldn't open a separate issue for visibility.
JustFly1984 commentedon Sep 1, 2021
@jamiechong you can use
yarnandresolutionsfield in package.json to force exact version of dependencies. But be careful, it could break things.matheo commentedon Jan 2, 2022
@developit can
node-fetchbe updated tov3.1.0please?developit commentedon Jan 2, 2022
@matheo want to open a PR?
RishikeshDarandale commentedon Feb 3, 2022
@developit , I tried my best to create #156 , but I am stuck to fix the test cases. Can you please take a look?