Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle the table of content resource type correctly #148

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emmanuel-deloget
Copy link

All ICNS resource type entries are made of a type and a length. The resource type is always a 4 byte string - if it's shorter than 4 bytes, it is filled with space (0x20) characters. This is also the case for the 'TOC ' resource type, so add the missing space character.

All ICNS resource type entries are made of a type and a length.
The resource type is always a 4 byte string - if it's shorter
than 4 bytes, it is filled with space (0x20) characters. This
is also the case for the 'TOC ' resource type, so add the
missing space character.

Signed-off-by: Emmanuel Deloget <[email protected]>
Copy link

changeset-bot bot commented Feb 12, 2025

⚠️ No Changeset found

Latest commit: ec3f618

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@emmanuel-deloget
Copy link
Author

It should be noted that I had to implement this fix in order to be able to build our electron-based application, where our icons are stored in ICNS files for both our Linux and MacOS builds.

Modern ICNS tools often add a TOC\0x20 entry in the resource list, and that may not have been the case before. Add this to the fact that most linux-based builds are not based upon ICNS files and that should explain why this issue may not have been detected for 7 years (the fixed line was last changed in 2018).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant