Skip to content

[node] - Node 18 EOL changes #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+24 −10
Open

[node] - Node 18 EOL changes #1349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
324b928
Node 18 EOL changes
Kaniska244 Apr 25, 2025
9ae64f3
Fixing failing tests
Kaniska244 Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/node/devcontainer-feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "node",
"version": "1.6.2",
"version": "1.6.3",
"name": "Node.js (via nvm), yarn and pnpm",
"documentationURL": "https://github.com/devcontainers/features/tree/main/src/node",
"description": "Installs Node.js, nvm, yarn, pnpm, and needed dependencies.",
Expand All @@ -11,9 +11,8 @@
"lts",
"latest",
"none",
"18",
"16",
"14"
"22",
"20"
],
"default": "lts",
"description": "Select or enter a Node.js version to install"
Expand Down
2 changes: 1 addition & 1 deletion test/node/install_additional_node.sh
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ set -e
source dev-container-features-test-lib

# 'lts' is now some version of node 20...
check "version_on_path" node -v | grep 20
check "version_on_path" node -v | grep 22
check "pnpm" bash -c "pnpm -v | grep 8.8.0"

check "v20_installed" ls -1 /usr/local/share/nvm/versions/node | grep 20
Expand Down
2 changes: 1 addition & 1 deletion test/node/install_additional_node_on_rhel_family.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ set -e
source dev-container-features-test-lib

# 'lts' is now some version of node 20...
check "version_on_path" node -v | grep 20
check "version_on_path" node -v | grep 22
check "pnpm" bash -c "pnpm -v | grep 6.16.0"

check "v20_installed" ls -1 /usr/local/share/nvm/versions/node | grep 20
Expand Down
15 changes: 15 additions & 0 deletions test/node/install_node_22_on_jammy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
#!/bin/bash

set -e

# Optional: Import test library
source dev-container-features-test-lib

# Definition specific tests
check "version" bash -c "node --version | grep 22"
check "pnpm" bash -c "pnpm -v | grep 8.8.0"
check "nvm" bash -c ". /usr/local/share/nvm/nvm.sh && nvm install 10"

# Report result
reportResults

8 changes: 4 additions & 4 deletions test/node/scenarios.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,11 @@
}
}
},
"install_node_16_on_bionic": {
"image": "mcr.microsoft.com/devcontainers/base:ubuntu-18.04",
"install_node_22_on_jammy": {
"image": "mcr.microsoft.com/devcontainers/base:ubuntu-22.04",
"features": {
"node": {
"version": "16",
"version": "22",
"pnpmVersion":"8.8.0"
}
}
Expand Down Expand Up @@ -200,4 +200,4 @@
}
}
}
}
}