Skip to content

Devcontainer feature list: add cargo-lambda package #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: gh-pages
Choose a base branch
from
Open

Devcontainer feature list: add cargo-lambda package #536

wants to merge 4 commits into from
+5 −0

Conversation

tokidoki11
Copy link

@tokidoki11 tokidoki11 commented Mar 6, 2025 •
edited
Loading

What type of PR is this?

  • Add a new dev container collection
  • Update to an existing dev container collection
  • Documentation/spec update
  • Other containers.dev site update (UX, layout, etc)

Related Issues

  • Related Issue #
  • Closes #

Description

Added a devcontainer feature for cargo-lambda in feature list yaml

Collection checklist

If your PR contributes a new collection, please utilize this checklist:

  • Collection name
  • Maintainer name
  • Maintainer contact link (i.e. link to a GitHub repo, email)
  • Repository URL
  • OCI Reference
  • I acknowledge that this collection provides new functionality, distinct from the existing collections part of this index.

@tokidoki11 tokidoki11 requested a review from a team as a code owner March 6, 2025 23:47
@Kaniska244
Copy link

Thank you for the PR. This can be merged.

With Regards,
Kaniska

@tokidoki11
Copy link
Author

@Kaniska244 I cant merge because no approval yet

ddoyle2017
ddoyle2017 previously approved these changes Apr 9, 2025
View reviewed changes
Copy link

@ddoyle2017 ddoyle2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Please address the merge conflicts

@tokidoki11 tokidoki11 requested a review from ddoyle2017 April 21, 2025 08:19
@tokidoki11
Copy link
Author

@ddoyle2017 I fix the conflict + update link to the github 63adf46

@tokidoki11
Copy link
Author

@ddoyle2017 Hi, could you please have a review on this PR again?

Thank you!

@tokidoki11
Copy link
Author

@ddoyle2017 bumping the review request :)

@tokidoki11
Copy link
Author

@Kaniska244 @ddoyle2017 bumping the review request :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddoyle2017 ddoyle2017 Awaiting requested review from ddoyle2017

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tokidoki11 @Kaniska244 @ddoyle2017