Fix filename bug, remove php close tag#1
Open
bruno-barros wants to merge 3 commits intoderricksmith:masterfrom
Open
Fix filename bug, remove php close tag#1bruno-barros wants to merge 3 commits intoderricksmith:masterfrom
bruno-barros wants to merge 3 commits intoderricksmith:masterfrom
Conversation
Author
|
humm forgot the last feature. On media popup, when changing the secure rule updates the URL dynamically. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The $meta array is not always an array, so on my server, the file name was converted to "_".
I checked if is array, if not convert the variable to an array.
includes/mgjp-functions.php on line 212
On mgjp_get_attachment_by_post_name() the way it finds the attachment based on the filename is totally unsure if you apply a filter when process upload. I stored a metadata '_wp_attachment_filename' to match the filename and fallback to the previous behavior.
Remove closing PHP tag to prevent to send unexpected data to the browser.