Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes for compatibility #3

Merged
merged 2 commits into from
Nov 22, 2019
Merged

Minor fixes for compatibility #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bba08e
add proper named exports
Nov 22, 2019
0ab5b1c
add missing default value for optional args
Nov 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions AxeObserver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export default class AxeObserver {
]
},
axeCoreInstanceCallback
}
} = {}
) {
if (typeof violationsCallback !== 'function') {
throw new Error(
Expand All @@ -53,7 +53,7 @@ export default class AxeObserver {
// Configure axe
axeCore.configure(axeCoreConfiguration)
}
observe(targetNode, { debounceMs = 1000, maxWaitMs = debounceMs * 5 }) {
observe(targetNode, { debounceMs = 1000, maxWaitMs = debounceMs * 5 } = {}) {
if (!targetNode) {
throw new Error('AxeObserver.observe requires a targetNode')
}
Expand Down
7 changes: 4 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import AxeObserver from './AxeObserver.js'
import logViolations from './logViolations.js'
import _AxeObserver from './AxeObserver.js'
import _logViolations from './logViolations.js'

export default { AxeObserver, logViolations }
export const AxeObserver = _AxeObserver
export const logViolations = _logViolations