Add initial version #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 19, 2019 15:22
jul-sh
commented
Nov 19, 2019
jul-sh
commented
Nov 19, 2019
added 2 commits
November 20, 2019 11:05
jul-sh
force-pushed
the
develop
branch
4 times, most recently
from
346faa7 to
cf289f9
Compare
add basic readme
jul-sh
force-pushed
the
develop
branch
2 times, most recently
from
7988e37 to
b395a59
Compare
# Conflicts: # README.MD
package.json
Outdated
| @@ -0,0 +1,46 @@ | |||
| { | |||
| "name": "agnostic-axe", | |||
| "version": "0.0.1", | |||
There was a problem hiding this comment.
This is not a valid SemVer version. :)
There was a problem hiding this comment.
Fair :). Made this 1.0.0
|
|
||
| ```js | ||
| import('agnostic-axe').then(({ AxeObserver, logViolations }) => { | ||
| const MyAxeObserver = new AxeObserver(logViolations) |
There was a problem hiding this comment.
I would recommend accepting an object of options. That will save you from breaking the API later on.
There was a problem hiding this comment.
Good point, agreed. Updated both the constructor & observe method to support that.
KittyGiraudel
approved these changes
Nov 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.