#1436 refactor unit tests to use a single test database #1629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eads. #1436 Co-authored-by: Kyle MacMillan <[email protected]>
Co-authored-by: edwardcass <[email protected]>
kalbfled
force-pushed
the
1436-2
branch
5 times, most recently
from
f8ccb47 to
e3ecf99
Compare
Co-authored-by: Kyle MacMillan <[email protected]> Co-authored-by: Michael Wellman <[email protected]>
cris-oddball
requested changes
Feb 6, 2024
|
|
||
| # TODO - Catch db connection errors and retry? | ||
| with get_reader_session() as reader_session: | ||
| query = select(Template).where(Template.id == request_data['template_id']) | ||
| try: | ||
| # TODO - This should intead use reader_session.get which returns an object or None |
There was a problem hiding this comment.
Typo in instead
TODOs need ticket numbers. Please add one.
| @@ -196,6 +188,7 @@ def v3_send_email_notification( | |||
| # Persist the notification so related model instances are available to downstream code. | |||
| notification.status = NOTIFICATION_CREATED | |||
| db.session.add(notification) | |||
| # TODO - Is this necessary? The template isn't being modified. Refreshing fails. | |||
There was a problem hiding this comment.
TODOs need ticket numbers. Please add it.
|
Superceeded by PR 1633. |
EvanParish
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor unit tests to use a single test database. These changes are extensive but follow a few themes:
There are several follow-up tickets associated with this work, as noted in the comments on the ticket.
#1436
Type of change
Please check the relevant option(s).
How Has This Been Tested?
How has this been tested? (e.g. Unit tests, Tested locally, Tested as a GitHub action, Depoyed to dev, etc)
Please provide relevant information and / or links to demonstrate the functionality or fix. (e.g. screenshots, link to deployment, regression test results, etc)
Checklist