Skip to content

Commit

Permalink
escape dot in maker regex (#357)
Browse files Browse the repository at this point in the history
* escape dot in maker regex

* Create test_typecheck_handler

* Rename test_typecheck_handler to test_typecheck_handler.vader
  • Loading branch information
bounceme authored and w0rp committed Feb 21, 2017
1 parent 6f6c156 commit 78b05d3
Show file tree
Hide file tree
Showing 2 changed files with 32 additions and 1 deletion.
2 changes: 1 addition & 1 deletion ale_linters/typescript/typecheck.vim
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ function! ale_linters#typescript#typecheck#Handle(buffer, lines) abort
" hello.ts[7, 41]: Property 'a' does not exist on type 'A'
" hello.ts[16, 7]: Type 'A' is not assignable to type 'B'
"
let l:pattern = '.\+.ts\[\(\d\+\), \(\d\+\)\]: \(.\+\)'
let l:pattern = '.\+\.ts\[\(\d\+\), \(\d\+\)\]: \(.\+\)'
let l:output = []

for l:line in a:lines
Expand Down
31 changes: 31 additions & 0 deletions test/test_typecheck_handler.vader
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
Execute(The typecheck handler should parse lines correctly):
runtime ale_linters/typescript/typecheck.vim

AssertEqual
\ [
\ {
\ 'bufnr': 347,
\ 'lnum': 16,
\ 'vcol': 0,
\ 'col': 7,
\ 'text': "Type 'A' is not assignable to type 'B'",
\ 'type': 'E',
\ 'nr': -1,
\ },
\ {
\ 'bufnr': 347,
\ 'lnum': 7,
\ 'vcol': 0,
\ 'col': 41,
\ 'text': "Property 'a' does not exist on type 'A'",
\ 'type': 'E',
\ 'nr': -1,
\ },
\ ],
\ ale_linters#typescript#typecheck#Handle(347, [
\ "somets.ts[16, 7]: Type 'A' is not assignable to type 'B'",
\ "somets.ts[7, 41]: Property 'a' does not exist on type 'A'",
\ ])

After:
call ale#linter#Reset()

0 comments on commit 78b05d3

Please sign in to comment.