Remove style classification from E999 (#696)

* Remove style classification from E999 * Update test_flake8_handler to reflect E999 changes
dense-analysis · Jun 27, 2017 · 14cca6d · 14cca6d
1 parent 16ba9bd
commit 14cca6d
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/ale_linters/python/flake8.vim b/ale_linters/python/flake8.vim
@@ -136,7 +136,7 @@ function! ale_linters#python#flake8#Handle(buffer, lines) abort
         \   'type': 'W',
         \}
 
-        if l:code[:0] ==# 'F'
+        if l:code[:0] ==# 'F' || l:code ==# 'E999'
             let l:item.type = 'E'
         elseif l:code[:0] ==# 'E'
             let l:item.type = 'E'

diff --git a/test/handler/test_flake8_handler.vader b/test/handler/test_flake8_handler.vader
@@ -4,7 +4,7 @@ Before:
 After:
     call ale#linter#Reset()
 
-Execute(The flake8 handler should handle basic warnings):
+Execute(The flake8 handler should handle basic warnings and syntax errors):
   AssertEqual
   \ [
   \   {
@@ -21,10 +21,17 @@ Execute(The flake8 handler should handle basic warnings):
   \     'text': 'W123: some warning',
   \     'sub_type': 'style',
   \   },
+  \   {
+  \     'lnum': 8,
+  \     'col': 3,
+  \     'type': 'E',
+  \     'text': 'E999: SyntaxError: invalid syntax',
+  \   },
   \ ],
   \ ale_linters#python#flake8#Handle(1, [
   \   'stdin:6:6: E111 indentation is not a multiple of four',
   \   'stdin:7:6: W123 some warning',
+  \   'stdin:8:3: E999 SyntaxError: invalid syntax',
   \ ])
 
 Execute(The flake8 handler should set end column indexes should be set for certain errors):