Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): test on stable #3476

Merged
merged 7 commits into from
Oct 11, 2023
Merged

chore(ci): test on stable #3476

merged 7 commits into from
Oct 11, 2023

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jul 4, 2023

This change ensures CI passes on the latest stable release of Deno.

@iuioiua iuioiua requested a review from kt3k as a code owner July 4, 2023 02:19
@kt3k
Copy link
Member

kt3k commented Jul 4, 2023

Compatibility with stable deno is sometimes very difficult to keep (if deno canary has some changes with breaking nature), and in that case we have to prioritize canary (The latest CLI release needs to pass the latest std test cases). That is the reason we only run canary in std CI.

refs:

(I think there was also a case where it was impossible to pass both canary and stable CI in the past, but I don't find it now..)

@iuioiua
Copy link
Contributor Author

iuioiua commented Jul 4, 2023

(I think there was also a case where it was impossible to pass both canary and stable CI in the past, but I don't find it now..)

Yeah, I agree. To elaborate, I think this would be because the Deno and Standard Library APIs are becoming more stable over time.

@iuioiua
Copy link
Contributor Author

iuioiua commented Jul 16, 2023

This PR is ready for review.

@lino-levan
Copy link
Contributor

(I think there was also a case where it was impossible to pass both canary and stable CI in the past, but I don't find it now..)

This will be the case when we remove this ts-ignore (#3491) when it lands in canary but before it lands in stable.

@kt3k
Copy link
Member

kt3k commented Jul 18, 2023

I think we should start CI with stable CLI when we released stable version of std. ref #3489

@iuioiua
Copy link
Contributor Author

iuioiua commented Sep 27, 2023

Actually, I think we should merge this before v1, so it's confirmed working fine for v1.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try and see.

@kt3k kt3k merged commit c028b8a into denoland:main Oct 11, 2023
@iuioiua iuioiua deleted the test-on-stable branch October 11, 2023 02:30
@kt3k
Copy link
Member

kt3k commented Dec 11, 2023

ref #3119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants