-
Notifications
You must be signed in to change notification settings - Fork 643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): test on stable #3476
Conversation
Compatibility with stable deno is sometimes very difficult to keep (if deno canary has some changes with breaking nature), and in that case we have to prioritize canary (The latest CLI release needs to pass the latest std test cases). That is the reason we only run canary in std CI. refs: (I think there was also a case where it was impossible to pass both canary and stable CI in the past, but I don't find it now..) |
Yeah, I agree. To elaborate, I think this would be because the Deno and Standard Library APIs are becoming more stable over time. |
This PR is ready for review. |
This will be the case when we remove this ts-ignore (#3491) when it lands in canary but before it lands in stable. |
I think we should start CI with stable CLI when we released stable version of std. ref #3489 |
Actually, I think we should merge this before v1, so it's confirmed working fine for v1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try and see.
ref #3119 |
This change ensures CI passes on the latest stable release of Deno.