Skip to content

fix(ext/canvas): createImageBitmap must ignore the Blob.type value #28741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 8, 2025

Conversation

Hajime-san
Copy link
Contributor

fixes #28723

I might misunderstood the spec. We should always sniff the MIME type from the byte sequence when the input is Blob.

@Hajime-san Hajime-san marked this pull request as draft April 4, 2025 03:23
@Hajime-san Hajime-san marked this pull request as ready for review April 4, 2025 04:31
Copy link
Member

@crowlKats crowlKats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crowlKats crowlKats merged commit 53b5111 into denoland:main May 8, 2025
18 checks passed
@Hajime-san Hajime-san deleted the fix-createimagebitmap-blob-type branch May 8, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling createImageBitmap with non-typed Blob causing InvalidStateError
3 participants